Optimized GuigraphicsMixin's code #956
Conversation
|
Why is this using |
Do you have an example? |
I found this in GeckoLib: https://github.com/bernie-g/geckolib/blob/refs%2Fheads%2Fmain/common%2Fsrc%2Fmain%2Fjava%2Fsoftware%2Fbernie%2Fgeckolib%2Fmixin%2Fclient%2FTextureManagerMixin.java#L42-L47 |
Looks like normal to me, the invoke target contains the same args as the injected method, not extra args from parent method |
|
Oh, I missed that the first parameter was the instance being called on and just counted the params. |
| if (kjs$itemSize[0] != 0) { | ||
| cir.setReturnValue(KubeJSClient.drawStackSize((GuiGraphics) (Object) this, font, kjs$itemSize[0], kjs$itemSize[1], kjs$itemSize[2], color, dropShadow)); | ||
| @WrapWithCondition(method = "renderItemDecorations(Lnet/minecraft/client/gui/Font;Lnet/minecraft/world/item/ItemStack;IILjava/lang/String;)V", at= @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/GuiGraphics;drawString(Lnet/minecraft/client/gui/Font;Ljava/lang/String;IIIZ)I")) | ||
| private boolean kjs$drawSize(GuiGraphics instance, Font font, String text, int x, int y, int color, boolean dropShadow, @Local(argsOnly = true) ItemStack stack, @Local(argsOnly = true, ordinal = 0) int pX, @Local(argsOnly = true, ordinal = 1) int pY, @Local(argsOnly = true) String pText) { |
There was a problem hiding this comment.
| private boolean kjs$drawSize(GuiGraphics instance, Font font, String text, int x, int y, int color, boolean dropShadow, @Local(argsOnly = true) ItemStack stack, @Local(argsOnly = true, ordinal = 0) int pX, @Local(argsOnly = true, ordinal = 1) int pY, @Local(argsOnly = true) String pText) { | |
| private boolean kjs$drawSize(GuiGraphics instance, Font font, String text, int x, int y, int color, boolean dropShadow, Font font2, ItemStack stack, int pX, int pY, String pText) { |
There was a problem hiding this comment.
I'm not sure how good using the arg append method is vs using specific @Local(argsOnly = true) parameters, but this is what I was referring to above.
There was a problem hiding this comment.
The change you're suggesting is just to make the method have one more Font parameter to be passed in
There was a problem hiding this comment.
Yes, but it avoids using @Local which in some cases can be a bad thing. I'm not sure if it is here though.
Description
use WrapWithCondition instead of multiple Inject
Other details