Remove explicit keycloak version parameter #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averevki
previously approved these changes
Nov 20, 2025
trepel
previously approved these changes
Nov 26, 2025
Collaborator
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
The parameter is systematically removed from all affected files. LGTM.
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
keycloak_delete
branch
from
8675a23 to
16ad497
Compare
Contributor
Author
|
^ rebase due to merge conflicts |
trepel
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added as a quick fix due to hard coded keycloak version. Now it can be set with
additional-helm-flagsso to reduce number of non-needed parameters I opt to remove it.