-
Notifications
You must be signed in to change notification settings - Fork 3
Switch Python linting and formatting to Ruff #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,16 +1,16 @@ | ||||||
| .PHONY: format format-yaml lint test test-js precommit setup | ||||||
|
|
||||||
| format: | ||||||
| uv run black . | ||||||
| prettier --write app/static/js/**/*.js app/static/css/**/*.css | ||||||
| uv run ruff format . | ||||||
| prettier --write app/static/js/**/*.js app/static/css/**/*.css | ||||||
|
Comment on lines
+4
to
+5
|
||||||
|
|
||||||
| format-yaml: | ||||||
| prettier --write '*.yml' | ||||||
|
||||||
| prettier --write '*.yml' | |
| prettier --write '*.yml' |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile recipes must be indented with tabs, not spaces. Replace the space indentation with tabs for all three recipe lines.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Keep Python modules PEP8 compliant with `black` formatting. | ||
| Keep Python modules PEP8 compliant with `ruff format`. | ||
| Use descriptive docstrings for all public functions and classes. | ||
| Prefer type hints. | ||
| Avoid introducing heavy dependencies without discussion. | ||
| Run `flake8` and `pytest` before committing changes. | ||
| Run `ruff check` and `pytest` before committing changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
formatandlinttargets now use space indentation for their commands instead of tabs (uv run ruff…lines), so GNU Make treats those lines as malformed and exits with*** missing separator. Runningmake formatormake lintcurrently fails before any Ruff tooling runs. Replacing the leading spaces with tabs (as still used by thetesttarget below) restores working developer workflows.Useful? React with 👍 / 👎.