Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 buy buttons for wp #281

Closed
wants to merge 8 commits into from
Closed

2 buy buttons for wp #281

wants to merge 8 commits into from

Conversation

dlaxcess
Copy link
Contributor

@dlaxcess dlaxcess commented Oct 4, 2022 •
edited
Loading

See issue 2-buy buttons for wp #228

@dlaxcess dlaxcess linked an issue Oct 4, 2022 that may be closed by this pull request
2 - BUY buttons for WP #228
Closed
@dlaxcess dlaxcess modified the milestones: ASAP, AUTOMARKET Oct 4, 2022
@dlaxcess dlaxcess self-assigned this Oct 4, 2022
@dlaxcess dlaxcess requested a review from zapaz October 4, 2022 17:21
@dlaxcess dlaxcess mentioned this pull request Oct 5, 2022
Merged
zapaz
zapaz requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@zapaz zapaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small remarks plus this :

NeworkList has to include testnets for Wordpress (like in Dapp)

common/lib/common/kconfig.ts
@@ -389,7 +389,10 @@ const explorerCollectionUrl = (chainId: number, collAddress = ""): string => {

// KREDEUM NFT URL
const kredeumNftUrl = (chainId: number, nft: NftType): string =>
`./#/${getChainName(nft.chainId)}/${nft?.address}/${nft?.tokenID}`;
`#/${getChainName(nft.chainId)}/${nft?.address}/${nft?.tokenID}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to check if direct NFT links still works with this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this to make it work in wordpress.
Checked in dapp that stills working.

are you talking about another direct NFT link ?

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

"Click on the Copy Button to copy the shortcode in your clibboard and then paste it in a WordPress page." =>
"Click the "COPY" button to copy the shortcode to your clipboard, and then paste it in your WordPress page." =>

"Sell direclty on your website" => "SELL on your WordPress site"
"Sell on OpenSea" => "VIEW on OpenSea"
Capture d’écran 2022-10-13 à 14 53 19

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

no refresh after popup close

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

turn it red! (it's danger zone)
Capture d’écran 2022-10-13 à 15 00 47

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

On WP media library page (including Mint buttons), indicate somewhere in the page "Collection 0x123..432 on matic Network" (with link to settings to change it if wanted)

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

"VIEW NFT" from media library not working

@zapaz
Copy link
Member

zapaz commented Oct 13, 2022

shortcode sell not working

@dlaxcess
Copy link
Contributor Author

VIEW on OpenSea

Done

@dlaxcess
Copy link
Contributor Author

turn it red! (it's danger zone) Capture d’écran 2022-10-13 à 15 00 47

done

@dlaxcess
Copy link
Contributor Author

dlaxcess commented Oct 13, 2022 •
edited
Loading

no refresh after popup close

TODO Display modale & closure Issue #178

@dlaxcess
Copy link
Contributor Author

shortcode sell not working

What isn't working ?

@dlaxcess dlaxcess requested a review from zapaz October 13, 2022 14:45
@dlaxcess dlaxcess force-pushed the 2-BUY-buttons-for-WP branch from 41f1af3 to 3fda938 Compare October 14, 2022 10:16
@Kredeum Kredeum deleted a comment from dlaxcess Oct 14, 2022
@dlaxcess dlaxcess mentioned this pull request Oct 18, 2022
Merged
@zapaz
Copy link
Member

zapaz commented Oct 19, 2022

replace by PR #287

@zapaz zapaz closed this Oct 19, 2022
@zapaz zapaz deleted the 2-BUY-buttons-for-WP branch October 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zapaz zapaz Awaiting requested review from zapaz

Assignees

@dlaxcess dlaxcess

Labels
feature svelte / typescript ux / css User eXperience + Css
Projects
None yet
Milestone
AUTOMARKET
Development

Successfully merging this pull request may close these issues.

2 - BUY buttons for WP
2 participants
@dlaxcess @zapaz