feat(logging): correlate requests with X-Request-Id across logs and responses - #23
Open
jahrulezfrancis wants to merge 1 commit into
Open
feat(logging): correlate requests with X-Request-Id across logs and responses#23jahrulezfrancis wants to merge 1 commit into
jahrulezfrancis wants to merge 1 commit into
Conversation
…esponses Assign a UUID (or honor a valid inbound header) so operators can trace a single request from morgan and Winston through the HTTP response and error envelope.
Author
|
@merlik787-droi I'm still waiting for a review on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Request-Idvalues; generate UUID v4 otherwise.What changed
requestIdMiddleware+request-context(AsyncLocalStorage)requestId; Morgan logs:iderror.requestId;X-Request-Idon all responsesAPI.mdandOPERATIONS.mdKey implementation details
crypto.randomUUID())[A-Za-z0-9_.:-]; otherwise overwrite (never 4xx)Testing / verification
pnpm lintpnpm test:ci(333 passed)pnpm build— blocked by pre-existingreward.service.tsTS2554 (Errorcause / ES2020 lib); unrelated to this PRNotes
Related Issue
Closes #13