Skip to content

fix(entities): skip validate before submit certificates form #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(entities): skip validate before submit certificates form #2562

merged 1 commit into from
Oct 16, 2025
+2 −98

Conversation

kingyue737
Copy link
Member

@kingyue737 kingyue737 commented Oct 15, 2025 •
edited by atlassian bot
Loading

Summary

KM-1590
KM-1591

@kingyue737
Copy link
Member Author

tests passed:

https://github.com/Kong/konnect-ui-apps/pull/8813/commits/3d4e395e82aaa307c73cef6653593155728cc855
https://github.com/Kong/kong-admin/pull/4093/commits/5a137ce5a8eabb7246ed2ceef1f24fc2395ef849

@kingyue737 kingyue737 marked this pull request as ready for review October 16, 2025 04:41
@kingyue737 kingyue737 requested review from a team as code owners October 16, 2025 04:41
sumimakito
sumimakito approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kingyue737 kingyue737 merged commit c51acc0 into main Oct 16, 2025
10 checks passed
@kingyue737 kingyue737 deleted the fix/certificate-remove-validate branch October 16, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees

@kingyue737 kingyue737

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kingyue737 @sumimakito