Skip to content

fix(entities): skip validate before submit sni form #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(entities): skip validate before submit sni form #2558

wants to merge 2 commits into from
+0 −45

Conversation

kingyue737
Copy link
Member

@kingyue737 kingyue737 commented Oct 13, 2025 •
edited by atlassian bot
Loading

Summary

KM-1592

@kingyue737 kingyue737 requested review from a team as code owners October 13, 2025 10:20
@kingyue737
Copy link
Member Author

kingyue737 commented Oct 13, 2025 •
edited
Loading

@sumimakito I’m not sure if I understand the task correctly. All I need to do is remove the /validate API call before submitting the form, right?

@kingyue737 kingyue737 requested a review from sumimakito October 13, 2025 10:35
@Leopoldthecoder
Copy link
Member

Could you also remove the validate entry in this file?

@Leopoldthecoder
Copy link
Member

Leopoldthecoder commented Oct 13, 2025 •
edited
Loading

It's also recommended to pull the preview package (@kong-ui-public/entities-snis@pr-2558) in consuming apps (konnect-ui-apps and kong-admin) to ensure the change does not break any tests.

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-snis@pr-2558

@kingyue737
Copy link
Member Author

All tests passed

kong-admin: https://github.com/Kong/kong-admin/pull/4093/commits/fbfe645c771d785498e8d6b846ea68840d952be2
konnect: https://github.com/Kong/konnect-ui-apps/pull/8813/commits/9c82bad3b95acea23f6a408fbae8014796635333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sumimakito sumimakito Awaiting requested review from sumimakito

At least 1 approving review is required to merge this pull request.

Assignees

@kingyue737 kingyue737

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kingyue737 @Leopoldthecoder @kongponents-bot