-
Notifications
You must be signed in to change notification settings - Fork 12
feat(entities-plugins): datakit - value indicator #2543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new ValueIndicator component to the Datakit flow editor that displays visual indicators for special connections (vault connections and cross-phase connections) on flow nodes. The indicator shows an icon and additional count when multiple connections exist, with tooltips providing connection details.
- Added ValueIndicator component with support for input/output modes and reversed positioning
- Integrated ValueIndicator into FlowNode for displaying special input and output connections
- Modified FlowCanvas hover styles to prevent conflicts with ValueIndicator interactions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
ValueIndicator.vue | New component for displaying connection indicators with icons, counts, and tooltips |
FlowNode.vue | Integrated ValueIndicator components and added logic to detect special connections |
FlowCanvas.vue | Updated hover styles to exclude nodes with active ValueIndicator hover states |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Outdated
Show resolved
Hide resolved
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Show resolved
Hide resolved
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Outdated
Show resolved
Hide resolved
9f7d579
to
3820371
Compare
3820371
to
4675c47
Compare
...ges/entities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/FlowNode.vue
Outdated
Show resolved
Hide resolved
...ges/entities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/FlowNode.vue
Outdated
Show resolved
Hide resolved
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Outdated
Show resolved
Hide resolved
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Outdated
Show resolved
Hide resolved
...tities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/ValueIndicator.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary