Skip to content

Conversation

2eha0
Copy link
Contributor

@2eha0 2eha0 commented Oct 9, 2025

Summary

image

@2eha0 2eha0 requested a review from Copilot October 9, 2025 09:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new ValueIndicator component to the Datakit flow editor that displays visual indicators for special connections (vault connections and cross-phase connections) on flow nodes. The indicator shows an icon and additional count when multiple connections exist, with tooltips providing connection details.

  • Added ValueIndicator component with support for input/output modes and reversed positioning
  • Integrated ValueIndicator into FlowNode for displaying special input and output connections
  • Modified FlowCanvas hover styles to prevent conflicts with ValueIndicator interactions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
ValueIndicator.vue New component for displaying connection indicators with icons, counts, and tooltips
FlowNode.vue Integrated ValueIndicator components and added logic to detect special connections
FlowCanvas.vue Updated hover styles to exclude nodes with active ValueIndicator hover states

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@2eha0 2eha0 force-pushed the feat/datakit-value-indicator branch from 9f7d579 to 3820371 Compare October 9, 2025 09:26
@2eha0 2eha0 force-pushed the feat/datakit-value-indicator branch from 3820371 to 4675c47 Compare October 9, 2025 09:26
@2eha0 2eha0 marked this pull request as ready for review October 9, 2025 09:27
@2eha0 2eha0 requested review from a team as code owners October 9, 2025 09:27
Copy link
Member

@Justineo Justineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2eha0 2eha0 merged commit 7826af9 into main Oct 16, 2025
9 checks passed
@2eha0 2eha0 deleted the feat/datakit-value-indicator branch October 16, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants