-
Notifications
You must be signed in to change notification settings - Fork 12
feat(entities-*): datakit - vault resources [KM-1666] #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds vault resource management capabilities to the Datakit flow editor, introducing a new resources panel and vault secret picker functionality. The implementation enables users to manage vault secrets directly within the Datakit configuration interface.
- Refactored the side panel to support tabbed interface with nodes and resources sections
- Added vault resource management with CRUD operations for vault secrets
- Integrated vault secret picker with custom validation and form handling
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
VaultSecretPicker.vue | Enhanced to support custom titles, button text, and additional validation |
locales/en.json | Added translations for vault resource management UI |
schema/strict.ts | Added Vault type export for type safety |
store/store.ts | Updated to handle vault resources in config output |
store/init.ts | Refactored node building to support vault-specific configuration |
side-panel/ | New tabbed side panel structure with resources management |
node-forms/ | New vault field management components |
VaultSecretPicker.vue | New Datakit-specific vault secret picker implementation |
composables/useVaultForm.ts | New composable for vault CRUD operations |
FlowEditor.vue | Updated to pass resources in config changes |
constants.ts | Added z-index constant for panel layering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/entities/entities-plugins/src/components/free-form/Datakit/flow-editor/store/store.ts
Outdated
Show resolved
Hide resolved
packages/entities/entities-plugins/src/components/free-form/Datakit/flow-editor/node/vault.ts
Outdated
Show resolved
Hide resolved
...es/entities-plugins/src/components/free-form/Datakit/flow-editor/composables/useVaultForm.ts
Show resolved
Hide resolved
...ties/entities-plugins/src/components/free-form/Datakit/flow-editor/side-panel/VaultField.vue
Show resolved
Hide resolved
todo: save vault field order to __ui_data |
...ties/entities-plugins/src/components/free-form/Datakit/flow-editor/side-panel/VaultField.vue
Show resolved
Hide resolved
.../entities-plugins/src/components/free-form/Datakit/flow-editor/side-panel/ResourcesPanel.vue
Outdated
Show resolved
Hide resolved
The schema of |
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR:
|
Summary
KM-1666
Screen.Recording.2025-10-09.at.15.44.52.mov