Skip to content

Conversation

2eha0
Copy link
Contributor

@2eha0 2eha0 commented Sep 29, 2025

Summary

KM-1666

  • Refactored vault selector to support some customization abilities
  • Implemented resource panel in datakit
Screen.Recording.2025-10-09.at.15.44.52.mov

@2eha0 2eha0 changed the title feat: datakit vault panel feat(entities-*): datakit - vault resources [KM-1666] Oct 9, 2025
@2eha0 2eha0 requested a review from Copilot October 9, 2025 07:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds vault resource management capabilities to the Datakit flow editor, introducing a new resources panel and vault secret picker functionality. The implementation enables users to manage vault secrets directly within the Datakit configuration interface.

  • Refactored the side panel to support tabbed interface with nodes and resources sections
  • Added vault resource management with CRUD operations for vault secrets
  • Integrated vault secret picker with custom validation and form handling

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
VaultSecretPicker.vue Enhanced to support custom titles, button text, and additional validation
locales/en.json Added translations for vault resource management UI
schema/strict.ts Added Vault type export for type safety
store/store.ts Updated to handle vault resources in config output
store/init.ts Refactored node building to support vault-specific configuration
side-panel/ New tabbed side panel structure with resources management
node-forms/ New vault field management components
VaultSecretPicker.vue New Datakit-specific vault secret picker implementation
composables/useVaultForm.ts New composable for vault CRUD operations
FlowEditor.vue Updated to pass resources in config changes
constants.ts Added z-index constant for panel layering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@2eha0 2eha0 marked this pull request as ready for review October 9, 2025 07:57
@2eha0 2eha0 requested review from a team as code owners October 9, 2025 07:57
@2eha0
Copy link
Contributor Author

2eha0 commented Oct 13, 2025

todo: save vault field order to __ui_data

@2eha0
Copy link
Contributor Author

2eha0 commented Oct 13, 2025

todo: save vault field order to __ui_data

The schema of resources.vault has already restricted it to start with a letter, so maybe we don't have to store the order of fields in the UI data.

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-vaults@pr-2530
@kong-ui-public/entities-redis-configurations@pr-2530
@kong-ui-public/entities-plugins@pr-2530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants