feat(analytics): add single value simple chart [MA-3730] #2064
Conversation
| decimalPoints: { | ||
| type: 'number', | ||
| }, | ||
| syntheticsDataKey, |
There was a problem hiding this comment.
It doesn't look like this chart accepts a synthetics data key; I think you can remove this line until we decide that it actually needs one.
There was a problem hiding this comment.
Why does this file have changes?
There was a problem hiding this comment.
pnpm stylelint:fix command
| }, | ||
| }) | ||
|
|
||
| const record = computed((): AnalyticsExploreRecord => props.data.data[0]) |
There was a problem hiding this comment.
@adorack @filipgutica is my logic correct here in the sense that we only need the first record here? Explore queries without group by only return 1 event but asking in case I'm missing something here
There was a problem hiding this comment.
I think this is a fine assumption.
There was a problem hiding this comment.
May be it would be useful to throw a console warning if sigle value is being used with an explore result that has more than one record?
There was a problem hiding this comment.
Good call, added a console.warn in onMounted
portikM
force-pushed
the
feat/ma-3730-single-value-chart
branch
from
8dc8765 to
e4322ab
Compare
Summary
Addresses: https://konghq.atlassian.net/browse/MA-3730
Adds
SingleValuesimple chart, allows it to be used in dashboard rendererDemo: https://www.loom.com/share/2e13cf753a074640a45a3ea061bc8eb1?sid=885a0cb2-9322-4206-aed8-0285f114d314