fix(entities-shared) : KM-1029 objectsAreEqual #2056
+187
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
jw-foss
reviewed
Mar 25, 2025
Comment on lines
+17
to
+29
| const deepSort = (obj: Record<string, any>): Record<string, any> => { | ||
| if (Array.isArray(obj)) { | ||
| return sortBy(obj.map(deepSort), (item: any) => JSON.stringify(item)) | ||
| } else if (isPlainObject(obj)) { | ||
| const sortedObj: Record<string, any> = {} | ||
| Object.keys(obj) | ||
| .sort() | ||
| .forEach((key) => { | ||
| sortedObj[key] = deepSort(obj[key]) | ||
| }) | ||
| return sortedObj | ||
| } else { | ||
| return obj |
There was a problem hiding this comment.
I'm suspicious about this sort operation, in my understanding performing deep equal might not need a sort operation prior to comparison 🤔 Can we try a non-intrusive way for performing the comparison here? For instance, we compare the key first, if we found unmatched key, then the object is not equal, then compare the value, recursively perform the operation.
There was a problem hiding this comment.
+1, we can compare the keys first and exit early on any mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KM-1029
Make sure
objectsAreEqualsupports comparison of deeply nested objects and arrays.