Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): lifecycle view and tab partials #1908

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jan 22, 2025

Summary

  • <LifecycleView /> to show request lifecycles in flowcharts
  • <PayloadDisplay /> to show payload info like request/response headers/body
  • <SummaryViewTab /> to build up the tab for request lifecycle, info, and captured payload

KM-773

@sumimakito sumimakito force-pushed the KM-773-tracing-lifecycle branch 5 times, most recently from 4ea3439 to a797fe4 Compare January 23, 2025 03:44
@sumimakito sumimakito force-pushed the KM-773-tracing-lifecycle branch from a797fe4 to ddf239e Compare January 23, 2025 03:58
@sumimakito sumimakito marked this pull request as ready for review January 23, 2025 07:45
@sumimakito sumimakito requested review from kongponents-bot and a team as code owners January 23, 2025 07:45
@Leopoldthecoder
Copy link
Member

The code block always shows a horizontal scrollbar. Can this be removed?

image

@Leopoldthecoder
Copy link
Member

Sometimes the request latency is out of view when I open the summary view. Reproduction link: https://pr-5577--gateway-manager.cloud-preview.konghq.tech/us/gateway-manager/03a13dd9-cf6c-4f8c-b2f8-1c3fc34a4f29/active-tracing/sessions/01949224-c46e-7dcd-a2c6-9de98afcd7a8/traces/9513ffd6b98ea780b538ebd7fd292890

image

@sumimakito
Copy link
Member Author

Sometimes the request latency is out of view when I open the summary view…

@Leopoldthecoder Good catch. It seems that the fitView function provided by VueFlow would zoom in on the chart too much when we only have a few nodes. After adding maxZoom: 1 to fitView, it looks like this:

Before After
Screenshot 2025-01-23 at 16 27 29 Screenshot 2025-01-23 at 16 26 41

What do you think?

@Leopoldthecoder
Copy link
Member

Sometimes the request latency is out of view when I open the summary view…

@Leopoldthecoder Good catch. It seems that the fitView function provided by VueFlow would zoom in on the chart too much when we only have a few nodes. After adding maxZoom: 1 to fitView, it looks like this:

Before After
Screenshot 2025-01-23 at 16 27 29 Screenshot 2025-01-23 at 16 26 41
What do you think?

I think now it's better: it gives users the whole picture. 👍

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/tracing@pr-1908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants