Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make multimanager implement Runnable interface #7198

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Mar 5, 2025

What this PR does / why we need it:

This is needed to make it run as a Runnable in KGO's manager.

@czeslavo czeslavo self-assigned this Mar 5, 2025
@czeslavo czeslavo marked this pull request as ready for review March 5, 2025 08:10
@czeslavo czeslavo requested a review from a team as a code owner March 5, 2025 08:10
@czeslavo czeslavo enabled auto-merge (squash) March 5, 2025 08:32
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/kic-as-library@592974a). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/kic-as-library   #7198   +/-   ##
=====================================================
  Coverage                       ?   77.0%           
=====================================================
  Files                          ?     220           
  Lines                          ?   25206           
  Branches                       ?       0           
=====================================================
  Hits                           ?   19421           
  Misses                         ?    4797           
  Partials                       ?     988           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo merged commit cd93bbf into feat/kic-as-library Mar 5, 2025
54 checks passed
@czeslavo czeslavo deleted the chore/runnable-impl branch March 5, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants