[Backport release/3.1.x] deduplicate nil-weight targets (#5946) #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume the Kong default 100 weight for targets that have nil weight when being deduplicated. (cherry picked from commit b8f7eb5)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/3.1.x #6025 +/- ##
===============================================
Coverage ? 72.0%
===============================================
Files ? 177
Lines ? 18317
Branches ? 0
===============================================
Hits ? 13203
Misses ? 4153
Partials ? 961 ☔ View full report in Codecov by Sentry. |
randmonkey
changed the title
randmonkey
changed the title
programmer04
approved these changes
May 15, 2024
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9098997307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport #5946 to
release/3.1.x. This fixes a potential segfault.Which issue this PR fixes:
Special notes for your reviewer:
Since the
targetWeightOrDefaultis moved totraslator_upstreams.goinmain, the backporting requires to move the changes to the original filetranslator.go.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR