Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add logs to konnect license test #5858

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 11, 2024

What this PR does / why we need it:

Add logs to Konnect license e2e test for easier debugging failures like https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8641557356/job/23691285205#step:8:98

konnect_test.go:98: 
        	Error Trace:	/home/runner/work/kubernetes-ingress-controller/kubernetes-ingress-controller/test/e2e/konnect_test.go:98
        	Error:      	Condition never satisfied
        	Test:       	TestKonnectLicenseActivation
    control_plane.go:68: deleting test Konnect Control Plane: "5eb8f77c-6890-4b2f-ad93-960f88a600d7"
2024/04/11 04:45:25 [DEBUG] GET https://global.api.konghq.tech/v2/users/me
2024/04/11 04:45:25 [DEBUG] GET https://global.api.konghq.tech/v2/users/515d12f2-aab2-42b3-a093-6ad793c0c7ab/assigned-roles?filter%5Bentity_type_name%5D=Runtime+Groups
    control_plane.go:89: deleting test Konnect Control Plane role: "d23d9621-dab6-439f-b[97](https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8641557356/job/23691285205#step:8:98)1-8b4894836eb8"
2024/04/11 04:45:25 [DEBUG] DELETE https://global.api.konghq.tech/v2/users/515d12f2-aab2-42b3-a093-6ad793c0c7ab/assigned-roles/d23d9621-dab6-439f-b971-8b4894836eb8
    helpers_test.go:114: TestKonnectLicenseActivation failed, dumped diagnostics to /tmp/ktf-diag-1807785900

@pmalek pmalek self-assigned this Apr 11, 2024
@pmalek pmalek requested a review from a team as a code owner April 11, 2024 08:35
@pmalek pmalek added the ci/run-e2e Trigger e2e test run from PR label Apr 11, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8643871510

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0%. Comparing base (ea1864c) to head (b16a162).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5858     +/-   ##
=======================================
+ Coverage   72.0%   74.0%   +1.9%     
=======================================
  Files        178     178             
  Lines      18210   18210             
=======================================
+ Hits       13127   13479    +352     
+ Misses      4107    3734    -373     
- Partials     976     997     +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit 8e54ae9 into main Apr 11, 2024
194 checks passed
@pmalek pmalek deleted the e2e-add-logs-to-konnect-test branch April 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants