refactor: bump KTF to v0.46.0 and adjust code accordingly #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5735 +/- ##
=======================================
+ Coverage 71.7% 71.9% +0.1%
=======================================
Files 175 175
Lines 18141 18141
=======================================
+ Hits 13023 13049 +26
+ Misses 4174 4152 -22
+ Partials 944 940 -4 ☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
bump-ktf
branch
2 times, most recently
from
452cc11 to
c8d0f55
Compare
programmer04
force-pushed
the
bump-ktf
branch
4 times, most recently
from
d968eaf to
d58719c
Compare
programmer04
force-pushed
the
bump-ktf
branch
3 times, most recently
from
fd97a7f to
dc4a4ab
Compare
programmer04
added
the
do not merge
programmer04
force-pushed
the
bump-ktf
branch
5 times, most recently
from
52a52ca to
7b5ac98
Compare
programmer04
removed
the
do not merge
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8392975533 |
pmalek
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Get rid of a workaround in getting particular URLs for Gateway. The limitation of KTF has been fixed in Kong/kubernetes-testing-framework#1008 and released in KTF v0.46.0 thus helpers can be used directly. Moreover, some small, opportunistic cleanups were spotted during the main task
Which issue this PR fixes:
Spotted during the fight with test flakes.