tests: fix e2e tests by installing incubator CRDs #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8326505052 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5711 +/- ##
=======================================
- Coverage 73.5% 73.5% -0.1%
=======================================
Files 175 175
Lines 18141 18141
=======================================
- Hits 13351 13341 -10
- Misses 3821 3833 +12
+ Partials 969 967 -2 ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following can be observed in KIC logs in e2e tests (in downloaded diagnostics):
It seems that
KongServiceFacadeis not installed by default in e2e tests because it's not packaged in default CRD kustomization (nor is it packaged with all in one manifests that we use for e2e tests) but the default feature gates env flag used in tests does enable its usage:kubernetes-ingress-controller/test/consts/feature_gates.go
Line 8 in 96941c3
This PR makes e2e tests install incubator CRDs via
confifg/rbac/incubatorkustomization dirWhich issue this PR fixes:
Special notes for your reviewer: