Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin Kuma version in E2E tests #5562

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 5, 2024

What this PR does / why we need it:

Pins Kuma Helm chart version used in E2E tests to a version defined in test_dependencies.yaml file as it is done for other dependencies. It will be auto-updated by renovate.

It also bumps KTF dependency to v0.45.0 (it fixed Kuma's addon's WithVersion which didn't work as expected before and adapted to Kuma's 2.6.0 changes that made default traffic permissions to not be created).

Which issue this PR fixes:

Fixes #5563.

Kuma tests started to fail after Kuma's 2.6.0 release that stopped creating default traffic permissions. Without them, traffic between Kong and upstream Services didn't work as expected.

@czeslavo czeslavo self-assigned this Feb 5, 2024
@czeslavo czeslavo added dependencies Pull requests that update a dependency file area/tests ci/run-e2e Trigger e2e test run from PR labels Feb 5, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7788870520

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Feb 5, 2024
@czeslavo czeslavo force-pushed the tests/pin-kuma-version branch from ffd531e to ed65d16 Compare February 5, 2024 18:05
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45d35cd) 71.7% compared to head (ed65d16) 71.8%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5562   +/-   ##
=====================================
  Coverage   71.7%   71.8%           
=====================================
  Files        176     176           
  Lines      18085   18085           
=====================================
+ Hits       12978   12986    +8     
+ Misses      4164    4157    -7     
+ Partials     943     942    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo marked this pull request as ready for review February 5, 2024 19:19
@czeslavo czeslavo requested a review from a team as a code owner February 5, 2024 19:19
@czeslavo czeslavo enabled auto-merge (squash) February 5, 2024 19:34
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Feb 5, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7789887971

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Feb 5, 2024
@czeslavo czeslavo merged commit 2575826 into main Feb 5, 2024
185 checks passed
@czeslavo czeslavo deleted the tests/pin-kuma-version branch February 5, 2024 20:15
@team-k8s-bot
Copy link
Collaborator

The backport to release/2.12.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5562-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2575826fc38a39e922c4e3917042942a87ef9979
# Push it to GitHub
git push --set-upstream origin backport-5562-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x

Then, create a pull request where the base branch is release/2.12.x and the compare/head branch is backport-5562-to-release/2.12.x.

@pmalek
Copy link
Member

pmalek commented Mar 25, 2024

@randmonkey This will sadly need to be manually cherry picked 😿

randmonkey pushed a commit that referenced this pull request Mar 26, 2024
randmonkey pushed a commit that referenced this pull request Mar 26, 2024
randmonkey pushed a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests backport release/2.12.x dependencies Pull requests that update a dependency file size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kuma v2.6.0 breaks E2E tests
5 participants