-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: pin Kuma version in E2E tests #5562
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7788870520 |
ffd531e
to
ed65d16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5562 +/- ##
=====================================
Coverage 71.7% 71.8%
=====================================
Files 176 176
Lines 18085 18085
=====================================
+ Hits 12978 12986 +8
+ Misses 4164 4157 -7
+ Partials 943 942 -1 ☔ View full report in Codecov by Sentry. |
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7789887971 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5562-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2575826fc38a39e922c4e3917042942a87ef9979
# Push it to GitHub
git push --set-upstream origin backport-5562-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x Then, create a pull request where the |
@randmonkey This will sadly need to be manually cherry picked 😿 |
(cherry picked from commit 2575826)
(cherry picked from commit 2575826)
(cherry picked from commit 2575826)
What this PR does / why we need it:
Pins Kuma Helm chart version used in E2E tests to a version defined in
test_dependencies.yaml
file as it is done for other dependencies. It will be auto-updated by renovate.It also bumps KTF dependency to v0.45.0 (it fixed Kuma's addon's
WithVersion
which didn't work as expected before and adapted to Kuma's 2.6.0 changes that made default traffic permissions to not be created).Which issue this PR fixes:
Fixes #5563.
Kuma tests started to fail after Kuma's 2.6.0 release that stopped creating default traffic permissions. Without them, traffic between Kong and upstream Services didn't work as expected.