Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kube-proxy-rbac #956

Merged
merged 2 commits into from
Jan 14, 2025
Merged

chore: remove kube-proxy-rbac #956

merged 2 commits into from
Jan 14, 2025

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Dec 25, 2024

What this PR does / why we need it:

Which issue this PR fixes

Fixes #399

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@tao12345666333
Copy link
Member Author

The CI blocked by #993

@tao12345666333 tao12345666333 force-pushed the remove-kube-rbac-proxy branch 3 times, most recently from 0684cc6 to 20aebe8 Compare January 13, 2025 13:20
@tao12345666333 tao12345666333 marked this pull request as ready for review January 13, 2025 14:12
@tao12345666333 tao12345666333 requested a review from a team as a code owner January 13, 2025 14:12
@tao12345666333 tao12345666333 self-assigned this Jan 13, 2025
modules/manager/run.go Outdated Show resolved Hide resolved
modules/cli/cli.go Outdated Show resolved Hide resolved
modules/cli/cli.go Outdated Show resolved Hide resolved
@randmonkey
Copy link
Contributor

@tao12345666333 Please run gofmt.

Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
@tao12345666333 tao12345666333 enabled auto-merge (squash) January 14, 2025 13:11
@tao12345666333 tao12345666333 requested a review from pmalek January 14, 2025 13:13
@tao12345666333 tao12345666333 merged commit 1c6bf26 into main Jan 14, 2025
24 checks passed
@tao12345666333 tao12345666333 deleted the remove-kube-rbac-proxy branch January 14, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removed support for kube-rbac-proxy in Kubebuilder v4
3 participants