Skip to content

feat: [INFRA] Optimize Storage Architecture for State Archival Limits #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Queenode merged 4 commits into from
Aug 22, 2026
Merged

feat: [INFRA] Optimize Storage Architecture for State Archival Limits #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23ae13a
feat: optimize storage rent with MemberState packing, dynamic TTL, an…
Skinny001 Aug 22, 2026
1c6cdfd
merge: sync with main (new trigger_payout test snapshots)
Skinny001 Aug 22, 2026
e15ffd0
merge: resolve main sync - fix test.rs for new initialize signature, …
Skinny001 Aug 22, 2026
0e26ee4
fix: add #[allow(clippy::unnecessary_cast)] for necessary usize->u32 …
Skinny001 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
309 changes: 158 additions & 151 deletions contracts/src/lib.rs
View file
Open in desktop

Large diffs are not rendered by default.

166 changes: 24 additions & 142 deletions contracts/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ fn test_initialize() {
&GroupType::Rotational,
&None,
&false,
&None,
);
}

Expand All @@ -51,6 +52,7 @@ fn test_double_initialize() {
&GroupType::Rotational,
&None,
&false,
&None,
);
client.initialize(
&admin,
Expand All @@ -60,6 +62,7 @@ fn test_double_initialize() {
&GroupType::Rotational,
&None,
&false,
&None,
);
}

Expand All @@ -83,6 +86,7 @@ fn test_add_member() {
&GroupType::Rotational,
&None,
&false,
&None,
);

env.mock_all_auths();
Expand Down Expand Up @@ -112,6 +116,7 @@ fn test_contribute_not_member() {
&GroupType::Rotational,
&None,
&false,
&None,
);

env.mock_all_auths();
Expand Down Expand Up @@ -141,6 +146,7 @@ fn test_contribute_twice_same_cycle_is_rejected() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -172,6 +178,7 @@ fn test_contribute_allowed_after_reset() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -206,6 +213,7 @@ fn test_events() {
&GroupType::Rotational,
&None,
&false,
&None,
);

assert_eq!(
Expand Down Expand Up @@ -268,6 +276,7 @@ fn test_goalbased_flexible_contributions() {
&GroupType::GoalBased,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -306,6 +315,7 @@ fn test_goalbased_partial_withdrawal() {
&GroupType::GoalBased,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -344,6 +354,7 @@ fn test_goalbased_over_withdrawal() {
&GroupType::GoalBased,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -376,6 +387,7 @@ fn test_goalbased_locked_until_target() {
&GroupType::GoalBased,
&Some(2000), // target amount
&true, // lock until target
&None, // expected_cycle_days
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -407,6 +419,7 @@ fn test_remove_member_no_contribution() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member1 = Address::generate(&env);
Expand Down Expand Up @@ -445,6 +458,7 @@ fn test_remove_member_with_contribution_refund() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member1 = Address::generate(&env);
Expand All @@ -464,12 +478,11 @@ fn test_remove_member_with_contribution_refund() {
assert_eq!(token_client.balance(&member2), 5000);

env.as_contract(&contract_id, || {
let has_contributed: bool = env
// MemberState entry removed entirely during remove_member (O(1) design)
assert!(!env
.storage()
.persistent()
.get(&DataKey::HasContributedThisCycle(member2.clone()))
.unwrap_or(false);
assert!(!has_contributed);
.instance()
.has(&DataKey::Member(member2.clone())));
});
}

Expand All @@ -495,6 +508,7 @@ fn test_remove_member_after_payout_panics() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member1 = Address::generate(&env);
Expand Down Expand Up @@ -533,6 +547,7 @@ fn test_remove_member_adjusts_cycle_count() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member1 = Address::generate(&env);
Expand Down Expand Up @@ -602,6 +617,7 @@ fn test_remove_last_member_clears_cycle_count() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member = Address::generate(&env);
Expand Down Expand Up @@ -646,6 +662,7 @@ fn test_deterministic_payout_order() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member0 = Address::generate(&env);
Expand Down Expand Up @@ -719,6 +736,7 @@ fn test_queue_enforced_payout_order() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member0 = Address::generate(&env);
Expand Down Expand Up @@ -784,6 +802,7 @@ fn test_cycle_resets_and_starts_again() {
&GroupType::Rotational,
&None,
&false,
&None,
);

let member0 = Address::generate(&env);
Expand Down Expand Up @@ -841,140 +860,3 @@ fn test_cycle_resets_and_starts_again() {
client.payout();
assert!(client.has_received_payout(&member0));
}

#[test]
fn test_trigger_payout_success() {
let env = Env::default();
env.mock_all_auths();
let contract_id = env.register_contract(None, KoloSavingsContract);
let client = KoloSavingsContractClient::new(&env, &contract_id);

let admin = Address::generate(&env);
let token_admin = Address::generate(&env);
let token = env.register_stellar_asset_contract(token_admin.clone());
let name = String::from_str(&env, "Test Group");
let contribution_amount = 1000;

client.initialize(
&admin,
&token,
&name,
&contribution_amount,
&GroupType::Rotational,
&None,
&false,
);

// Add two members (member1 index 0, member2 index 1)
let member1 = Address::generate(&env);
let member2 = Address::generate(&env);
client.add_member(&member1);
client.add_member(&member2);

// Fund the token contract so members have tokens to contribute
let token_client = token::Client::new(&env, &token);
let stellar_asset = token::StellarAssetClient::new(&env, &token);
for member in [&member1, &member2] {
stellar_asset.mint(member, &5000);
}

// Both members contribute
client.contribute(&member1, &1000);
client.contribute(&member2, &1000);

// Member 2 triggers payout to member 1 (who is next in queue at index 0)
let initial_balance = token_client.balance(&member1);
client.trigger_payout(&member2, &member1);
let final_balance = token_client.balance(&member1);

// Verify payout was received (2 members * 1000 = 2000)
assert_eq!(final_balance, initial_balance + 2000);
}

#[test]
#[should_panic(expected = "Pool is not full")]
fn test_trigger_payout_pool_not_full() {
let env = Env::default();
env.mock_all_auths();
let contract_id = env.register_contract(None, KoloSavingsContract);
let client = KoloSavingsContractClient::new(&env, &contract_id);

let admin = Address::generate(&env);
let token_admin = Address::generate(&env);
let token = env.register_stellar_asset_contract(token_admin.clone());
let name = String::from_str(&env, "Test Group");
let contribution_amount = 1000;

client.initialize(
&admin,
&token,
&name,
&contribution_amount,
&GroupType::Rotational,
&None,
&false,
);

// Add two members
let member1 = Address::generate(&env);
let member2 = Address::generate(&env);
client.add_member(&member1);
client.add_member(&member2);

// Fund the token contract
let stellar_asset = token::StellarAssetClient::new(&env, &token);
for member in [&member1, &member2] {
stellar_asset.mint(member, &5000);
}

// Only member1 contributes (pool not full)
client.contribute(&member1, &1000);

// Attempt to trigger payout should fail
client.trigger_payout(&member2, &member1);
}

#[test]
#[should_panic(expected = "Caller is not a member")]
fn test_trigger_payout_non_member() {
let env = Env::default();
env.mock_all_auths();
let contract_id = env.register_contract(None, KoloSavingsContract);
let client = KoloSavingsContractClient::new(&env, &contract_id);

let admin = Address::generate(&env);
let token_admin = Address::generate(&env);
let token = env.register_stellar_asset_contract(token_admin.clone());
let name = String::from_str(&env, "Test Group");
let contribution_amount = 1000;

client.initialize(
&admin,
&token,
&name,
&contribution_amount,
&GroupType::Rotational,
&None,
&false,
);

// Add two members
let member1 = Address::generate(&env);
let member2 = Address::generate(&env);
client.add_member(&member1);
client.add_member(&member2);

// Fund the token contract
let stellar_asset = token::StellarAssetClient::new(&env, &token);
for member in [&member1, &member2] {
stellar_asset.mint(member, &5000);
}

// Both members contribute
client.contribute(&member1, &1000);
client.contribute(&member2, &1000);

// Non-member attempts to trigger payout
let non_member = Address::generate(&env);
client.trigger_payout(&non_member, &member1);
}
Loading
Loading