Have encode_to_slice() return a &mut str and add encode_fmt #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
api-niceties
branch
from
1e7b011 to
ec2e6ac
Compare
hkBst
suggested changes
Dec 31, 2024
Comment on lines
+462
to
+469
| for (out, byte) in output.chunks_exact_mut(2).zip(input) { | ||
| let (high, low) = byte2hex(*byte, table); | ||
| out[0] = high; | ||
| out[1] = low; | ||
| } | ||
|
|
||
| Ok(()) | ||
| // SAFETY: output was just fully filled with only ascii characters | ||
| let output = unsafe { core::str::from_utf8_unchecked_mut(output) }; |
There was a problem hiding this comment.
If input is an empty slice, then the zip is an empty iterator, and no data is written to output. Thus there is no reason to assume output contains valid utf8, though the subslice that was actually written does.
The above is wrong, because it was already checked if input.len() * 2 != output.len(), but maybe expand on the safety comment.
Owner
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some internal changes that I think make stuff more efficient.
A lot of the times I have a fixed length byte buffer to encode, but cause
encode_to_slicedoesn't give you access to a str you have to do a check or use unsafe to turn it into a str. This makes it likechar::encode_utf8(), where you encode into a buffer and then get to actually use the string from it right away. Alsoencode_fmtis nice for if something's in a Display/Debug implementation, or just if it's not necessary to allocate a whole separate string.