-
Notifications
You must be signed in to change notification settings - Fork 61
Improve performance of decoding #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Luro02
suggested changes
Aug 27, 2021
Contributor
Luro02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
This was referenced Nov 7, 2025
- Remove unused `u8` import from `core` module - Add lint allow annotation for `__` constant to suppress non_upper_case_globals warning - Refactor `decode_in_slice()` to use slice-based `val()` function for cleaner implementation
Co-authored-by: Lucas <[email protected]>
KokaKiwi
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes decoding about 10x faster than the current implementation, on my machine.
Before:
After:
Benchmarks per commit
Current main branch (aa8f300)
First commit of this PR: Use lookup table for decoding (870590e)
Second commit of this PR: Inline val function (3b75b32)
Third commit of this PR: Use chunks_exact instead of chunks (ff1d115)
Fourth commit of this PR: Use decode_to_slice in Vec::from_hex (4fd0ed8)
Fifth commit of this PR: Inline decode_to_slice function (3e2aa25)