-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New manufacturer : Yokis] Add support for several Yokis devices #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yokis: Adding Yokis custom cluster definition
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
Koenkk
reviewed
Dec 30, 2024
- Removed unused vars - Renamed property names to snake_case - Renamed some properties to make sense more explicit (and not following technical name) - Reorganised some modernExtend inclusion
Thanks! |
Thank you @LaurentChardin ! Amazing work |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer : i do not represent Yokis company, but i was in contact with them to help add support for their devices into Zigbee2Mqtt. This is still a work in progress but the current status is very functional already.
This PR is the first iteration to provide support for Yokis products:
Some clusters are declared but not implemented, as some documentation is still pending and additional tests are required.
List of devices:
Another PR will be submitted to the documentation site shortly.