Repair ambiguous weekday routine cron handling#1235
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_taskroutinesMON-FRIcron fields during scheduler action create/reschedulethread_request.mdclearly asked for weekday executionRoot Cause
The scheduler cron parser does not behave like common Unix cron numeric weekday conventions. Legacy weekday schedules encoded with numeric weekday ranges such as
1-5could execute as Sunday-Thursday, which is why Work could show4/5while the confirmation email said the routine should start on4/3.Testing
cargo fmt --all --manifest-path DoWhiz_service/Cargo.tomlcargo test --manifest-path DoWhiz_service/Cargo.toml -p scheduler_module --lib resolve_schedule_request_with_context_cargo test --manifest-path DoWhiz_service/Cargo.toml -p scheduler_module --lib maybe_repair_legacy_weekday_cron_task_uses_thread_request_contextNotes