Fail clearly on unresolved shiv minor pins - #28
Merged
Conversation
ikma-ricon
approved these changes
Jul 7, 2026
ikma-ricon
left a comment
Contributor
There was a problem hiding this comment.
Approved. The failure policy is right: once BackendInstall is handed a partial numeric selector, delegating a fabricated v ref to shiv only obscures the resolver failure. Successful minor-stream fallback remains covered, and the new unit coverage hits both real failure modes in this path: tag lookup failure and fetched tags with no matching patch.\n\nI re-ran locally: mise exec -- lua test/lua/run.lua "/home/runner/agents/ikma/vfox-shiv", mise run test, and git diff --check origin/main...HEAD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.1cannot be resolved to a concrete release tagsms@v0.1after tag lookup failure or no matching patch tagContext
NVR's Fly remote builder hit this failure while installing
shiv:sms = "0.1"during a fresh Docker build:Minor-stream pins are valid and work locally. The misleading
v0.1came from vfox-shiv's install-time fallback path: when mise passes the raw minor version through toBackendInstall, vfox-shiv tries to resolve matching tags. If that lookup returns no versions, it currently returns the original partial version and then prefixes it withv.This PR keeps the existing successful path (
0.1-> latest matching0.1.x) and changes the failure path to stop in vfox-shiv with an explicit resolution error.Validation
lua test/lua/run.lua "$PWD"mise run test latest_refreshmise run testgit diff --checkgit pre-pushafter push: OK except expected “no local commits to push” warning