Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions test/conversation/conversation-recovery.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,17 @@ async function harness(): Promise<Harness> {

function appendTurn(manager: SessionManager, label: string): string {
manager.appendMessage({ role: "user", content: `${label} user`, timestamp: Date.now() });
return appendAssistant(manager, `${label} assistant`, "stop");
}

function appendAssistant(
manager: SessionManager,
content: string,
stopReason: "stop" | "error",
): string {
return manager.appendMessage({
role: "assistant",
content: [{ type: "text", text: `${label} assistant` }],
content: [{ type: "text", text: content }],
api: "openai-completions",
provider: "test",
model: "deterministic",
Expand All @@ -54,7 +62,8 @@ function appendTurn(manager: SessionManager, label: string): string {
totalTokens: 0,
cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 },
},
stopReason: "stop",
stopReason,
errorMessage: stopReason === "error" ? "fictional retryable failure" : undefined,
timestamp: Date.now(),
} as SessionMessage);
}
Expand Down Expand Up @@ -144,6 +153,42 @@ describe("committed conversation recovery", () => {
expect(context(recovered)).toContain("second assistant");
});

test("restores a committed retry without interpreting Pi message cardinality", async () => {
const state = await harness();
const manager = SessionManager.open(
state.sessionFile,
state.sessionDirectory,
state.workspaceDirectory,
);
manager.appendMessage({
role: "user",
content: "retried user",
timestamp: Date.now(),
});
appendAssistant(manager, "retryable error", "error");
const committedLeafId = appendAssistant(manager, "retried assistant", "stop");
const committed: ConversationHistorySnapshot = {
version: 1,
messages: [
{ role: "user", content: "retried user" },
{ role: "assistant", content: "retried assistant" },
],
committedLeafId,
};
await state.historyStore.save(state.conversationId, committed, activeSignal());

const stored = await state.historyStore.load(state.conversationId);
const recovered = reopen(state, stored);
const persistedMessageRoles = recovered.getBranch()
.filter((entry) => entry.type === "message")
.map((entry) => entry.message.role);

expect(stored.messages).toHaveLength(2);
expect(persistedMessageRoles).toEqual(["user", "assistant", "assistant"]);
expect(recovered.getLeafId()).toBe(committedLeafId);
expect(context(recovered)).toContain("retried assistant");
});

test("missing snapshot resets an abandoned first turn to committed root", async () => {
const state = await harness();
const manager = SessionManager.open(
Expand Down