fix: preserve custom mise data for target tools - #121
Merged
junior-ricon merged 1 commit intoJul 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding fixed
PR #120 retains the caller's mise shims so the target project can discover its own tools, but then clears every
MISE_*variable. A user-owned non-defaultMISE_DATA_DIRis required by those retained shims; clearing it makes them switch to the default data root, where they can fail offline or unexpectedly install a second copy.This keeps
MISE_DATA_DIRacross the final child boundary while continuing to scrub Sessions project/task activation (MISE_CONFIG_ROOT,MISE_TASK_*, and the other inheritedMISE_*values) plususage_*and caller-CWD context. Bash and Elixir launch paths preserve the same rule.Validation
mise run test: 321/321 BATS tests passmix test: 132 tests and 4 doctests passreadme build --checkgit diff --checkThe updated real Pi-adapter engine test and Bash run-boundary test assert that the selected custom mise data root reaches the final child while task context remains absent.