Pass 500/Exception handlers to both error middlewares #3081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the long-standing issue where custom
500andExceptionhandlers are excluded fromExceptionMiddleware, causing them to bypass the user middleware stack (includingCORSMiddleware).Problem
Currently in
build_middleware_stack(), handlers for500andExceptionare special-cased to only pass toServerErrorMiddlewareand are excluded fromExceptionMiddleware:This causes:
Solution
Remove the
elseclause so500/Exceptionhandlers are passed to both middlewares:This allows:
ExceptionMiddlewareto handle the exception first (inside user middleware stack)ServerErrorMiddlewareto act as a fallback for truly unhandled exceptionsRelated Issues
This addresses the root cause of many long-standing issues:
Starlette:
FastAPI (downstream impact):
Exceptionvia exception_handlers since FastAPI 0.70.0 fastapi/fastapi#4025 / Discussion #8647Backward Compatibility
ServerErrorMiddlewarestill provides debug tracebacks as fallback