Skip to content

fix: add websocket prefix to StreamingResponse and FileResponse denia… #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-joshy wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: add websocket prefix to StreamingResponse and FileResponse denia… #3051

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f70425a
fix: add websocket prefix to StreamingResponse and FileResponse denia…
martin-joshy Oct 29, 2025
87018a7
Revert "fix: add websocket prefix to StreamingResponse and FileRespon…
martin-joshy Oct 30, 2025
711e125
fix: add websocket prefix for all denial response (#3051)
martin-joshy Oct 30, 2025
852fb05
fix: add the return types as mentioned in the failed test
martin-joshy Oct 30, 2025
b882b3a
fix: check if the prefix is already added
martin-joshy Oct 30, 2025
d1a984e
Merge branch 'main' into fix/ws-denial-streaming
martin-joshy Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion starlette/websockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,23 @@ async def close(self, code: int = 1000, reason: str | None = None) -> None:

async def send_denial_response(self, response: Response) -> None:
if "websocket.http.response" in self.scope.get("extensions", {}):
await response(self.scope, self.receive, self.send)
wrapped_send = self._send_wrap(self.send, is_websocket_denial=True)
await response(self.scope, self.receive, wrapped_send)
else:
raise RuntimeError("The server doesn't support the Websocket Denial Response extension.")

@staticmethod
def _send_wrap(send: Send, is_websocket_denial: bool) -> Send:
async def wrapped(message: Message) -> None:
message_type = message["type"]
if is_websocket_denial:
if not message_type.startswith("websocket."):
message["type"] = "websocket." + message_type

await send(message)

return wrapped


class WebSocketClose:
def __init__(self, code: int = 1000, reason: str | None = None) -> None:
Expand Down
Loading