Disclaimer Modal - use local storage#2406
Open
0xMakka wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Looks good! |
0xtapi
approved these changes
Dec 13, 2024
jabby09
approved these changes
Dec 13, 2024
Collaborator
Author
|
Bumping this if one of you has a free minute to review @must-be-carbon & @Atmosfearful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To avoid the disclaimer modal popping up so frequently due to using session storage - this PR utilizes local storage for determining to show the modal again as opposed to the current solution which is based on the users session.
Related Ticket
Closes #2405