Integrate CMARK credit retirements into RA#74
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAurelius
force-pushed
the
cmark-retire
branch
from
2db7810 to
bb25d7b
Compare
0xAurelius
changed the title
psparacino
requested changes
Jan 7, 2025
psparacino
reviewed
Jan 8, 2025
psparacino
reviewed
Jan 8, 2025
psparacino
approved these changes
Jan 8, 2025
Contributor
Author
|
Plan is to run through a local test of the upgrade for this change, meeting with @Atmosfearful next week to go over that |
Atmosfearful
approved these changes
Feb 6, 2025
| details | ||
| ); | ||
|
|
||
| return LibRetire.getTotalRetirements(details.beneficiaryAddress); |
Collaborator
There was a problem hiding this comment.
Just curious, how does this value actually get incremented? Is it a side effect of retireCMARK() -> saveRetirementDetails() ?
0xAurelius
force-pushed
the
cmark-retire
branch
from
16a0a89 to
df72b23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the code should work now, though I'm still working on the test (I can't get it to work with a local fork, I think it's a problem with my local setup)
Appreciate any input or feedback