Skip to content

Conversation

@sankhesh
Copy link
Collaborator

@sankhesh sankhesh commented Sep 18, 2025

Rolled back to v4.9.0

Context

Updating webpack-dev-server in 3953b55 to v5.2.2 caused the incompatibility with parallel-webpack and had the following issue:

[webpack-cli] Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.
 - options has an unknown property '_assetEmittingPreviousFiles'. These properties are valid:
   object { allowedHosts?, bonjour?, client?, compress?, devMiddleware?, headers?, historyApiFallback?, host?, hot?, ipc?, liveReload?, onListening?, open?, port?, proxy?, server?, app?, setupExitSignals?, setupMiddlewares?, static?, watchFiles?, webSocketServer? }

Related: #3313 (comment)

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@jourdain
Copy link
Collaborator

It has been too long, I let Julien take the lead on that one.

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem future-proof however... but if you can still do npm run example AnExampleHere from a fresh build, then I guess it's fine by me.

@sankhesh sankhesh added this pull request to the merge queue Sep 19, 2025
Merged via the queue into Kitware:master with commit 8f8e3c2 Sep 19, 2025
2 checks passed
@github-actions
Copy link

🎉 This PR is included in version 34.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 19, 2025
@sankhesh sankhesh deleted the webpack-examples-fix branch September 22, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants