Skip to content

Add GraphQL relationship filters #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

williamjallen
Copy link
Collaborator

The existing GraphQL filter input currently only allows users to filter by fields directly on the underlying table being filtered. This PR improves the filter input by allowing users to search by relationships as well. In other words, it's now possible to answer queries like "give me the list of builds which have a test named xyz". These filters can be infinitely nested, essentially giving users the ability to query anything in the CDash database, subject to access control limitations. This is an extremely powerful capability which will enable improvements to existing pages, brand new pages which were not previously possible, and 3rd-party extensions using the API.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We talked about the things that i experienced and have a plan to deal with them. I'll leave this off the merge queue until Zack gets a chance to look at it.

@williamjallen williamjallen marked this pull request as draft May 28, 2025 14:41
@williamjallen williamjallen modified the milestones: v4.0, v4.1 May 28, 2025
@williamjallen williamjallen force-pushed the graphql-filter-by-relationship branch from e7d7ac0 to f4ce1a8 Compare June 5, 2025 12:53
@williamjallen williamjallen marked this pull request as ready for review June 5, 2025 13:12
@williamjallen williamjallen added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@williamjallen williamjallen added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@williamjallen
Copy link
Collaborator Author

It looks like GitHub is having some issues this morning. I'll re-queue this later today...

@williamjallen williamjallen added this pull request to the merge queue Jun 9, 2025
Merged via the queue into Kitware:master with commit 14d0bee Jun 9, 2025
7 checks passed
@williamjallen williamjallen deleted the graphql-filter-by-relationship branch June 9, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants