Skip to content

Conversation

n7studios
Copy link
Contributor

Summary

Adds a method for fetching a list of broadcast's stats.

Testing

  • testGetBroadcastsStats : Test that get_broadcasts_stats() returns the expected data and pagination works.
  • testGetBroadcastsStatsWithTotalCount: Test that get_broadcasts_stats() includes the total count when required.

Checklist

@n7studios n7studios added this to the 2.2.1 milestone Sep 30, 2025
@n7studios n7studios self-assigned this Sep 30, 2025
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team October 1, 2025 10:26
@n7studios n7studios marked this pull request as ready for review October 1, 2025 10:26
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how necessary it is to test pagination on every request that uses pagination. Thoughts?

@n7studios
Copy link
Contributor Author

I don't know how necessary it is to test pagination on every request that uses pagination. Thoughts?

Probably overkill, but it would cover a scenario where (I!) accidentally were to remove pagination arguments from a method, as tests would then fail.

@n7studios n7studios merged commit f2adc1b into fix-tests Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants