Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the sprocket installation script to update all deno tasks containing sprocket package references, rather than only updating a hardcoded "sprocket" task. The changes include refactoring the install logic with proper validation, better error handling, and support for both string tasks and structured task definitions.
Changes:
- Refactored install.ts to iterate through all tasks and update any containing sprocket references
- Added validation module with Zod schemas for type-safe validation of deno.json structure
- Created type definitions for deno configuration objects and task structures
- Updated dependencies (zod, detect-indent, neverthrow, and various
@stdpackages)
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| installation/install.ts | Refactored to scan all tasks for sprocket references and update versions; added validation and better error handling |
| installation/core/validation.ts | New module providing Zod-based validation for DenoConfig, Task, and TaskDefinition types |
| installation/core/deno.ts | New module defining TypeScript types for deno configuration structures |
| dev-tools/create-pr.ts | Reordered base branch options (cosmetic change) |
| deno.json | Updated dependency versions for @std libraries, zod, neverthrow; added detect-indent |
| deno.lock | Updated lock file to reflect new dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KinsonDigitalAdmin
previously approved these changes
Feb 20, 2026
CalvinWilkinson
force-pushed
the
feature/102-improve-install-process
branch
from
55b9d6e to
22ade18
Compare
KinsonDigitalAdmin
previously approved these changes
Feb 20, 2026
github-project-automation
bot
moved this from 🏗️In Development
to ↪️PR Complete (Needs Merging)
in KD-Team
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CalvinWilkinson
force-pushed
the
feature/102-improve-install-process
branch
from
74b2981 to
833095e
Compare
KinsonDigitalAdmin
approved these changes
Feb 20, 2026
github-project-automation
bot
moved this from ↪️PR Complete (Needs Merging)
to ✅Done
in KD-Team
CalvinWilkinson
added a commit
that referenced
this pull request
Feb 20, 2026
* Start work for issue #102 * enhance: improve the install process * deps: update all dependencies * refactor: update imports to import type to follow standards * config: swap branch order in create pr dev tool * refactor: adjust code to meet coding standards * pr-review: implement requested changes * pr-review: implement requested changes * pr-review: implement requested changes * pr-review: implement requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this pull request is to implement the changes described in the linked issue.
This pull request closes #102.
Unrelated Changes
List the changes that were made that were unrelated to the linked issue.
Reviewer Notes
Add additional notes about what the reviewer should focus on.