Repository navigation
Conversation
Allow a spawning Cloud Agent to choose between resuming the parent chat and opening a new chat in the parent workspace for a child's completion result. The new chat uses a server-minted sibling runtime authorization and a deterministic destination derived from the persisted callback message ID, so queue retries stay idempotent. Callback payloads now include the destination session id.
| } | ||
| return { type: 'success' }; | ||
| } catch (error) { | ||
| const permanent = |
There was a problem hiding this comment.
SUGGESTION: Terminal authorization denials are classified as transient and retried five times.
authorizeCloudAgentWorkspaceSibling (line 87) and assertCloudAgentParentAuthority throw plain Error values — e.g. Cloud Agent parent authority denied for a revoked/disabled parent or a non-anchor parent — and the destination-mismatch TRPCError CONFLICT on line 104 is likewise unrecoverable. Because permanent only recognizes the five TRPCError codes above, all of these report status: 503 and go through the full 5-attempt backoff before the callback is dropped, unlike the session:parent path which fails these fast through resolveParentCallbackSession's FORBIDDEN. Consider classifying the known denial errors (or throwing a TRPCError/shared denial code from the authority helper) so a revoked parent fails once.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Executive SummaryNo blocking defect was found in the new child-callback workspace-chat path; the only finding is that terminal authorization denials are classified as transient and retried instead of failing fast. Assumptions: Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (26 files)
Fix these issues in Kilo Cloud Reviewed by deepseek-flash-latest · Input: 118.5K · Output: 50.4K · Cached: 4.4M Review guidance: REVIEW.md from base branch |
Summary
session:parent) or a new chat in the parent workspace (workspace:new-chat).callbackSessionIdso the receiving agent knows its own session.Verification
pnpm --filter cloud-agent-next typecheckpnpm --filter cloud-agent-next test(6726 tests)pnpm --filter kilo-mcp test(673 tests)pnpm --filter @kilocode/worker-utils test(1193 tests)pnpm --filter cloud-agent-next check:duplication