Repository navigation
fix(cloud-agent): remember environments and preserve default profiles - #9723
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the environment-choice persistence and the V2 default-profile change across the shared resolution package, web hooks/UI, tests, spec, and lockfile; client and server resolution stay aligned and no defects were found. Assumptions: none. Files Reviewed (15 files)
Reviewed by deepseek-flash-latest · Input: 102.3K · Output: 30K · Cached: 2.4M Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied the supplied patch unchanged to current
origin/main(fe50ac74d4af02555b9b1bfeab37cabb8a7d3356), without conflicts or adaptations. Reviewedgit diff origin/main...HEAD.Validation
v24.22.1, pnpm11.1.2.pnpm install --filter web... --filter @kilocode/cloud-agent-profile... --filter @kilocode/trpc... --frozen-lockfile --ignore-scripts: passed.packages/cloud-agent-profile,pnpm exec vitest run --no-file-parallelism: 324 tests passed across 17 files;pnpm typecheck: passed.apps/web,pnpm test --runInBand --runTestsByPath src/hooks/useSessionEnvironment.test.ts src/components/cloud-agent/ProfilePickerPopover.test.ts src/components/cloud-agent-next/environment-selection.test.ts src/components/cloud-agent-next/EnvironmentAccess.test.ts src/tests/cloud-agent-profile/profile-session-config.test.ts: 80 tests passed across all five suites. Used a local PostgreSQL 17 database with pgvector and the repository's unmodified Jest migration/setup flow; Docker is unavailable in this sandbox.pnpm exec oxlint --config .oxlintrc.jsonon all 12 changed TS/TSX files: passed.pnpm exec oxfmt --checkwith all 15 changed paths: passed (13 files matched after repository ignore rules).git diff --check origin/main...HEAD: passed.apps/webtypecheck was attempted withtimeout --kill-after=5s 195s pnpm typecheckbut did not complete within the limit. The tRPC build completed with Rollup warnings; the full web typecheck is not claimed as passing.