Repository navigation
fix(bouncer): set admission timeouts and fail closed for signup - #7293
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the bouncer timeout test adjustment found no issues; the change only replaces a pinned Files Reviewed (1 file)
Previous Review Summaries (2 snapshots, latest commit 2a200bf)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2a200bf)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the Bouncer fail-closed follow-up (timeout constants and the signup rejection-reason fix) found no remaining issues; the earlier rejection-reason misattribution is now fixed. Files Reviewed (3 files)
Previous review (commit aadb99c)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (12 files)
Reviewed by deepseek-v4.1-flash · Input: 31.1K · Output: 3.1K · Cached: 240.3K Review guidance: REVIEW.md from base branch |


Summary
SIGNUP-UNAVAILABLEwith retry guidance instead of an abuse message.Verification
Verified on a disposable Google Cloud VM with real PostgreSQL and local HTTP Bouncer and Stripe fixtures. All credentials were synthetic. Runtime egress was restricted to loopback.
SIGNUP-UNAVAILABLEin 3,013 ms, with no user, provider, or Stripe customer created.SIGNUP-RATE-LIMITED; report-only verdicts admitted signup.Baseline reproduction: stalled or delayed Bouncer responses created accounts after the old 500 ms timeout. A malformed verdict also created an account.
Visual Changes
Before/after screenshots are attached in the verification comment. No image files are committed.
Reviewer Notes