Repository navigation
Speed up Auto Efficient decisions and benchmark all reasoning efforts - #7273
Conversation
|
Verified against the live web app on the Google Cloud VM. The ranking data uses the explicitly labelled local vm-ui-smoke-fixture; these are not completed benchmark scores. The model selector and registry coverage use the actual catalog and queued profiles. Keyboard expansion and collapse passed. The screenshots show the 375px collapsed summary and the 1440px expanded exact-pair table. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change bounds the platform catalog fetch with a 10-second AbortSignal deadline that covers body reads, resolving the previously flagged unbounded queue-drain wait; no new issues found in the changed lines. Files Reviewed (3 files)
Previous Review Summary (commit 98fc417)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 98fc417)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe auto-routing/benchmark refactor is internally consistent and well-tested; the one concern is an unbounded catalog fetch newly added to the scheduled queue-drain path. Overview
Issue Details (click to expand)WARNING
Files Reviewed (30 files)
Reviewed by deepseek-v4.1-flash · Input: 36.6K · Output: 4.8K · Cached: 215K Review guidance: REVIEW.md from base branch |


Changes
VM measurements and decision
Used an e2-standard-8 Google Cloud VM in europe-west3-a.
Compared 72 golden cases, three repetitions per design, with interleaved ordering and concurrency three.
All requests resolved to typesafe/jev-1.13-20260917.
Keep the current payload: the split saved little routing latency, increased cost by 6.4%, and reduced the measured weighted score.
The implementation removes serial preparation waits instead.
Actual Worker HTTP measurements used 72 cold-session requests before and after, alternating constrained and unconstrained requests.
Constrained p95 fell 45.0% in this VM sample. These numbers do not establish production latency guarantees.
Verification
oddfor high and xhigh, with recorded cost.Reasoning is mandatory; failures remain visible.vm-ui-smoke-fixture, not completed benchmark scores.Updated the benchmark README and Auto Efficient architecture decision record. No database migration is required.