Repository navigation
refactor(web): move server helpers out of lib/utils - #6915
Merged
Merged
Conversation
lib/utils mixes the UI class-name and formatting helpers with helpers the gateway and billing code use, so server code loaded clsx, tailwind-merge and the Stripe payment-method types. The server helpers move unchanged: - getFraudDetectionHeaders and its types to lib/fraud-detection-headers - normalizeEmail and getLowerDomainFromEmail to lib/email-address - toMicrodollars to lib/microdollars - stripRequiredPrefix into llm-proxy, its only caller fromMicrodollars importers use @kilocode/app-shared/utils, which lib/utils only re-exported.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryVerified the verbatim move of Verification Notes
Files Reviewed (62 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
approved these changes
Sep 29, 2026
…-helpers # Conflicts: # apps/web/src/lib/organizations/organizations.test.ts
iscekic
added a commit
that referenced
this pull request
Sep 30, 2026
Resolve three conflicts. - Main moved `toMicrodollars` from `@/lib/utils` to `@/lib/microdollars` (#6915). Take the new path in both notification test files, and in the two credit pack files that the merge could not flag. - Regenerate `.kilo/skills/kilo-mcp/SKILL.md` from the merged catalog, so the drift check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/utilsmixes the UI class-name and formatting helpers with helpers that gateway and billing code use, so server code loadedclsx,tailwind-mergeand the Stripe payment-method types. The server helpers move unchanged:getFraudDetectionHeadersand its types →lib/fraud-detection-headersnormalizeEmailandgetLowerDomainFromEmail→lib/email-addresstoMicrodollars→lib/microdollarsstripRequiredPrefix→ intollm-proxy, its only callerImporters of
fromMicrodollarsnow use@kilocode/app-shared/utils, whichlib/utilsonly re-exported.Verification
Tests are left to CI. No manual checks are listed.
Visual Changes
N/A
Reviewer Notes
Split out of #6894, which prepares #6806 (the
ai-gatewayapp and theweb-sharedpackage). The move is verbatim; usegit show --color-movedto confirm it.