-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install qt commercial test #17
base: master_upstream
Are you sure you want to change the base?
Conversation
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
resolved_path = str(installer_path.resolve(strict=True)) | ||
return [resolved_path] | ||
|
||
cmd = self._resolve_path(installer_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue identified by Pylint, "Unreachable code," occurs because the line cmd = self._resolve_path(installer_path)
is placed after a return
statement in the _resolve_path
method. Once the return
statement is executed, the function exits, and any code following it will not be executed. Therefore, the assignment to cmd
will never happen.
To fix this issue, we need to move the cmd
assignment outside of the _resolve_path
method. Since the provided code fragment is incomplete, I will assume that the cmd
assignment is intended to be part of another method where _resolve_path
is called.
Here’s the single line change to fix the issue by moving the cmd
assignment outside of the _resolve_path
method:
cmd = self._resolve_path(installer_path) | |
cmd = self._resolve_path(installer_path) |
This line should be placed in the appropriate method where the installer path is being processed, ensuring that it is not within the _resolve_path
method itself.
This comment was generated by an experimental AI tool.
from logging.handlers import QueueHandler | ||
from pathlib import Path | ||
from shlex import shlex # Remove this line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue reported by Pylint indicates that the shlex
module is being imported, but it is not used anywhere in the code fragment. This is considered a code style issue because unnecessary imports can clutter the code and may lead to confusion.
To fix the issue, you can simply remove the unused import line. Here’s the code suggestion to address the problem:
from shlex import shlex # Remove this line | |
# Remove the line: from shlex import shlex # Remove this line |
This comment was generated by an experimental AI tool.
No description provided.