Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-qt-commercial feature and tests #16

Open
wants to merge 35 commits into
base: master_upstream
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
4180492
Add install-qt-commercial feature and tests
Kidev Jan 6, 2025
1fe3990
Make the auto-answers parameters, fix linter issues
Kidev Jan 6, 2025
3169929
Fork and execv instead of using subprocess
Kidev Jan 7, 2025
c13bbc2
Return to simpler process execution method version
Kidev Jan 8, 2025
0790ad3
Fix test
Kidev Jan 9, 2025
93f3a11
Move commercial installer into its own file
Kidev Jan 11, 2025
cfc21ab
Fix shadowing of symbol platform causing errors
Kidev Jan 11, 2025
c8d86dc
Adapt test_cli for argparse format changes on py 3.13+
Kidev Jan 11, 2025
399acf0
Fix some errors, monkeypatch install test
Kidev Jan 11, 2025
976998d
Add --override super command
Kidev Jan 11, 2025
330683a
Properly handle --override and grab all the remaining commands when n…
Kidev Jan 11, 2025
fcb9805
Fix tests
Kidev Jan 12, 2025
0973ecc
Add base for modules, some niche features are not yet entirely implem…
Kidev Jan 12, 2025
686fc43
Fix some mistakes
Kidev Jan 12, 2025
4e3d0e2
Fix errors made with the monkeypatch, update Settings to make sure it…
Kidev Jan 12, 2025
fcd55e1
Tests commercial (#20)
Kidev Jan 18, 2025
e9ae059
Fix windows issue
Kidev Jan 18, 2025
7b04ddf
Hidden summon works
Kidev Jan 18, 2025
084e198
Remove both subprocess direct calls
Kidev Jan 18, 2025
1952019
Dipose of temp folder
Kidev Jan 18, 2025
de2baf0
Fix path issue
Kidev Jan 18, 2025
b0a5ec6
Add list-qt-commercial command
Kidev Jan 18, 2025
b126bc6
Fix help info
Kidev Jan 18, 2025
b77e810
Make no params valid for list-qt-commercial
Kidev Jan 18, 2025
f1d436c
Fix lint errors, and param overflow when no args are passed to list
Kidev Jan 18, 2025
26dd68e
Fix search
Kidev Jan 18, 2025
55d6906
Add tests for coverage, fix lint
Kidev Jan 18, 2025
90b53f2
Test for overwriting, and for cache usage coverage
Kidev Jan 18, 2025
0db2724
Return to clean exec, ignoring CI fail to preserve code clarity
Kidev Jan 26, 2025
4e3e258
Fix parsing of subprocess.run output for some python versions
Kidev Jan 27, 2025
32fb34c
Make output more readable in console for list-qt-commercial
Kidev Jan 27, 2025
bc596cf
Forward email and password to list request for users without a qtacco…
Kidev Jan 27, 2025
2da233a
Change default settings
Kidev Jan 27, 2025
3fcf261
Fix lint errors
Kidev Jan 27, 2025
cd4cb2e
Fix check error
Kidev Jan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix search
  • Loading branch information
Kidev committed Jan 18, 2025
commit 26dd68ec906cb465501a9cb242a91344ecde22ed
7 changes: 3 additions & 4 deletions aqt/installer.py
Original file line number Diff line number Diff line change
@@ -864,10 +864,9 @@
"$ aqt list-qt-commercial gcc_64 6.8.1 # search for multiple terms at once\n",
)
list_parser.add_argument(
"-s",
"--search",
"search_terms",
nargs="*",
help="Optional search terms to pass to the installer search command. If not provided, lists all packages",
default="*",
)
list_parser.set_defaults(func=self.run_list_qt_commercial)

@@ -877,7 +876,7 @@

# Create temporary directory to download installer
import shutil
from pathlib import Path

Check warning on line 879 in aqt/installer.py

Codacy Production / Codacy Static Code Analysis

aqt/installer.py#L879

Reimport 'Path' (imported line 39)

temp_dir = Settings.qt_installer_temp_path
temp_path = Path(temp_dir)
@@ -913,7 +912,7 @@
"--accept-obligations",
"--confirm-command",
"search",
args.search,
"" if not args.search_terms else " ".join(args.search_terms),
]

# Run search and display output
Loading