-
Notifications
You must be signed in to change notification settings - Fork 1.2k
EXT_mesh_primitive_edge_visibility #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
e6c0837
EXT_mesh_primitive_edge_visibility
pmconne 771816c
tweaks
pmconne 9159f19
copyright
pmconne 7509571
address schema TODOs
pmconne 2bf3eea
require zero initialization.
pmconne 6809e9b
WIP revise
pmconne 00ed7a3
lineStrings
pmconne ee0d667
silhouettes
pmconne 9dfdb73
WIP example
pmconne 35c328b
lineStrings examples
pmconne 102f154
WIP update schema
pmconne 3530185
update schema
pmconne 8149190
/s/client/engine
pmconne 7b23b66
rendering requirements
pmconne a5fb723
rename schema
pmconne fff86b4
grammar
pmconne c449bbf
Expand title
pmconne 5df0dd9
fix winding order
pmconne 96aa219
update json schema
pmconne 9746de8
silhouette mates => silhouette normals
pmconne bf816db
oct16
pmconne e3e4cc5
update silhouette normal encoding
pmconne 07b8d8d
implementation note re silhouette normals
pmconne 3c7fc9d
Removed the copyright text in EXT_mesh_primitive_edge_visibility README
weegeekps 37038bd
Included a CC-BY-4.0 SPDX copyright line at the top of the file.
weegeekps a9ce053
Add SVG versions of original ASCII art figures.
markschlosseratbentley 8de356f
Add SVG versions of original ASCII art figures.
markschlosseratbentley 94aeded
add CesiumJS known implementation
markschlosseratbentley 8f80e89
Update README.md
danielzhong 8384b27
added diagrams, so editing README contributors
markschlosseratbentley 679bc5d
optimize PNG images
danielzhong 56863b6
Update README.md
danielzhong 7bdecf4
Update README.md
danielzhong 97cc365
Update lineString.schema.json
danielzhong e91be75
Update README.md
danielzhong 20946bb
Update README.md
danielzhong 64ed5be
Update README.md
danielzhong 998412b
Update extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/READM…
markschlosseratbentley df29fa4
license
markschlosseratbentley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
221 changes: 221 additions & 0 deletions
221
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/README.md
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file added
BIN
+5.31 KB
...nsions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/figures/depth-fighting.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+7.01 KB
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/figures/hard-edges.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.86 KB
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/figures/outline.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+7.06 KB
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/figures/visible-edges.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24.8 KB
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/figures/wiremesh.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 38 additions & 0 deletions
38
extensions/2.0/Vendor/EXT_mesh_primitive_edge_visibility/schema/lineString.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "$id": "lineString", | ||
| "title": "Line String", | ||
| "type": "object", | ||
| "description": "Represents one or more line strings to be drawn as edges of a triangle mesh", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFProperty.schema.json" | ||
| } | ||
| ], | ||
| "properties": { | ||
| "indices": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFid.schema.json" | ||
| } | ||
| ], | ||
| "description": "The index of the accessor that contains the vertex indices for the line strings", | ||
| "gltf_detailedDescription": "The index of the accessor that contains the vertex indices. The accessor **MUST** have `SCALAR` type and an unsigned integer component type. The indices are permitted to include the maximal index value for the component type, indicating the start of a new line string." | ||
| }, | ||
| "material": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFid.schema.json" | ||
| } | ||
| ], | ||
| "description": "The index of a glTF material with which the edges are to be drawn.", | ||
| "gltf_detailedDescription": "The index of a glTF material with which the edges are to be drawn. If omitted, the edges are drawn using the same material as the edges encoded by the extension's `visibility` field, or else that of the triangle mesh primitive." | ||
| }, | ||
| "name": {}, | ||
| "extensions": {}, | ||
| "extras": {} | ||
| }, | ||
| "required": [ | ||
| "indices" | ||
| ] | ||
| } | ||
51 changes: 51 additions & 0 deletions
51
...primitive_edge_visibility/schema/primitive.EXT_mesh_primitive_edge_visibility.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "EXT_mesh_primitive_edge_visibility glTF extension", | ||
|
pmconne marked this conversation as resolved.
Outdated
|
||
| "type": "object", | ||
| "description": "glTF extension encoding the visibility of the edges of a triangles primitive", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFProperty.schema.json" | ||
| } | ||
| ], | ||
| "properties": { | ||
| "visibility": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFid.schema.json" | ||
| } | ||
| ], | ||
| "description": "The index of the accessor encoding the visibility of each triangle edge as a bitfield with two bits per edge.", | ||
| "gltf_detailedDescription": "An edge visibility of 0 indicates the edge is never drawn; 1 indicates the edge is only drawn in silhouette; 2 indicates a 'hard' (always-drawn) edge; and 3 indicates a repeated occurrence of a 'hard' edge." | ||
| }, | ||
| "material": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFid.schema.json" | ||
| } | ||
| ], | ||
| "description": "The index of a glTF material with which the edges are to be drawn.", | ||
| "gltf_detailedDescription": "The index of a glTF material with which the edges are to be drawn. If omitted, the edges are drawn using the same material as the triangle mesh primitive." | ||
| }, | ||
| "silhouetteMates": { | ||
| "allOf": [ | ||
| { | ||
| "$ref": "glTFid.schema.json" | ||
| } | ||
| ], | ||
| "description": "The index of the accessor encoding the index of the fourth vertex for the pair of triangles sharing each silhouette edge (visibility 1) encoded in `visibility`.", | ||
| "gltf_detailedDescription": "This property **MUST** be defined if and only if `visibility` encodes at least one edge with visibility value `1`." | ||
| }, | ||
| "lineStrings": { | ||
| "type": "array", | ||
| "description": "An array of edges encoded as line strings.", | ||
| "gltf_detailedDescription": "Edges encoded as line strings **MUST NOT** also be encoded by the `visibility` property.", | ||
| "items": { | ||
| "$ref": "lineString.schema.json" | ||
| }, | ||
| "minItems": 1 | ||
| }, | ||
| "extensions": {}, | ||
| "extras": {} | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.