Enable multisampling and improve depth handling in rendering pipeline#86
Merged
Merged
Conversation
- Set up MSAA sample count using `getMaxUsableSampleCount()` and integrate it throughout the pipeline. - Add support for depth attachment in the pipeline with appropriate format detection. - Refactor image layout transitions to handle color, depth, and multisampled images. - Introduce `transition_image_layout_custom()` for flexible image layout transitions. - Update rendering pass to include multisampled color and depth attachments with clear values.
- Integrate depth attachment format detection into pipeline setup. - Transition depth images to optimal layouts for depth/stencil usage. - Include depth attachment in rendering configuration with appropriate clear values.
This was
unlinked from
issues
Jul 6, 2025
This was
linked to
issues
Jul 6, 2025
SaschaWillems
self-requested a review
July 6, 2025 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMaxUsableSampleCount()and integrate it throughout the pipeline.transition_image_layout_custom()for flexible image layout transitions.