Skip to content

Remove unused helper function #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaschaWillems wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused helper function #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions attachments/30_multisampling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,6 @@ class HelloTriangleApplication
vk::FormatFeatureFlagBits::eDepthStencilAttachment);
}

static bool hasStencilComponent(vk::Format format)
{
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

void createTextureImage()
{
int texWidth, texHeight, texChannels;
Expand Down
5 changes: 0 additions & 5 deletions attachments/32_ecosystem_utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,11 +843,6 @@ class HelloTriangleApplication
vk::FormatFeatureFlagBits::eDepthStencilAttachment);
}

static bool hasStencilComponent(vk::Format format)
{
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

void createTextureImage()
{
int texWidth, texHeight, texChannels;
Expand Down
5 changes: 0 additions & 5 deletions attachments/35_gltf_ktx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,11 +773,6 @@ class VulkanApplication
vk::FormatFeatureFlagBits::eDepthStencilAttachment);
}

static bool hasStencilComponent(vk::Format format)
{
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

void createTextureImage()
{
// Load KTX2 texture instead of using stb_image
Expand Down
5 changes: 0 additions & 5 deletions attachments/36_multiple_objects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,11 +844,6 @@ class VulkanApplication
vk::FormatFeatureFlagBits::eDepthStencilAttachment);
}

static bool hasStencilComponent(vk::Format format)
{
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

void createTextureImage()
{
// Load KTX2 texture instead of using stb_image
Expand Down
5 changes: 0 additions & 5 deletions attachments/38_ray_tracing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,11 +736,6 @@ class VulkanRaytracingApplication
vk::FormatFeatureFlagBits::eDepthStencilAttachment);
}

static bool hasStencilComponent(vk::Format format)
{
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

std::pair<vk::raii::Image, vk::raii::DeviceMemory> createTextureImage(const std::string &path)
{
int texWidth, texHeight, texChannels;
Expand Down
5 changes: 0 additions & 5 deletions attachments/advanced_gltf/renderer_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,6 @@ vk::Format Renderer::findDepthFormat() {
}
}

// Check if format has stencil component
bool Renderer::hasStencilComponent(vk::Format format) {
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

// Read file
std::vector<char> Renderer::readFile(const std::string& filename) {
try {
Expand Down
5 changes: 0 additions & 5 deletions attachments/openxr_engine/renderer_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ vk::Format Renderer::findDepthFormat() {
}
}

// Check if format has stencil component
bool Renderer::hasStencilComponent(vk::Format format) {
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

// Read file
std::vector<char> Renderer::readFile(const std::string& filename) {
try {
Expand Down
5 changes: 0 additions & 5 deletions attachments/simple_engine/renderer_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ vk::Format Renderer::findDepthFormat() {
}
}

// Check if format has stencil component
bool Renderer::hasStencilComponent(vk::Format format) {
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

// Read file
std::vector<char> Renderer::readFile(const std::string& filename) {
try {
Expand Down
5 changes: 0 additions & 5 deletions attachments/sync2_engine/renderer_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,6 @@ vk::Format Renderer::findDepthFormat() {
}
}

// Check if format has stencil component
bool Renderer::hasStencilComponent(vk::Format format) {
return format == vk::Format::eD32SfloatS8Uint || format == vk::Format::eD24UnormS8Uint;
}

// Resolve path
std::string Renderer::ResolvePath(const std::string& filename) const {
if (filename.empty()) return "";
Expand Down
Loading