Skip to content

Update static nav to match pages by full href, not just basename#215

Merged
marty-johnson59 merged 2 commits into
KhronosGroup:mainfrom
gpx1000:fix-left-panel-nav
Jul 13, 2026
Merged

Update static nav to match pages by full href, not just basename#215
marty-johnson59 merged 2 commits into
KhronosGroup:mainfrom
gpx1000:fix-left-panel-nav

Conversation

@gpx1000

@gpx1000 gpx1000 commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

closes #213

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Preview site published: https://KhronosGroup.github.io/Vulkan-Site/PR-215/

@SaschaWillems

Copy link
Copy Markdown
Collaborator

Thanks for fixing. The preview site linked above does give a 404. Is there a way to test without having to build the site locally?

@gpx1000

gpx1000 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

https://github.com/KhronosGroup/Vulkan-Site/actions/runs/28766630605 I'd have to think through a bigger fix. Sadly due to the space limitations on gh-pages, these PR changes just mean that non-changed files are routed back to the top level site. So, if you hit introduction, you'd be looking at the non-changed site at the top level and seeing the problem again.

https://github.com/KhronosGroup/Vulkan-Site/actions/runs/28766630605

That has the full site build, download it and browse locally is really the easiest way to get it. It could take a bit for me to really figure out a good solution to the space problem...

@SaschaWillems

Copy link
Copy Markdown
Collaborator

Thanks. Did test with the full site download and this works as expected for me.

@SaschaWillems SaschaWillems self-requested a review July 10, 2026 15:26
@marty-johnson59 marty-johnson59 merged commit 917b88e into KhronosGroup:main Jul 13, 2026
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Navigation jumps to first page of the same name

3 participants