Cleanup on debug callback. - #1560
Merged
Merged
Conversation
asuessenbach
force-pushed
the
debug_callback
branch
from
August 17, 2026 09:12
a0e2740 to
9405418
Compare
asuessenbach
force-pushed
the
debug_callback
branch
from
August 18, 2026 07:03
9405418 to
fb3556c
Compare
tomek-brcm
approved these changes
Aug 24, 2026
asuessenbach
force-pushed
the
debug_callback
branch
from
August 25, 2026 12:49
957dba4 to
17690d4
Compare
tomek-brcm
approved these changes
Sep 9, 2026
gpx1000
approved these changes
Sep 9, 2026
SaschaWillems
approved these changes
Sep 10, 2026
SaschaWillems
left a comment
Collaborator
There was a problem hiding this comment.
If this approach is considered to be good, I'd carry it over to all the other occurances of a debug callback.
I'm fine with this approach and applying it to other occurrences in the samples.
Contributor
|
Merging - 3 approvals |
tomek-brcm
reviewed
Sep 11, 2026
| { | ||
| // Log debug message | ||
| if (message_severity & vk::DebugUtilsMessageSeverityFlagBitsEXT::eWarning) | ||
| std::string message = std::format("Debug callback {}\n{}: {}", vk::to_string(message_type), callback_data->pMessageIdName, callback_data->pMessage); |
Contributor
There was a problem hiding this comment.
This requires C++20, I'll add a tiny patch to remove the requirement.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The debug callback is called with just one severity bit, depending on the
MessageSeveritybits used on creation.There might be multiple bits in the
MessageTypeargument.That is, the
message_type, as well as thecallback_dataare used in the generated message, while themessage_severitydetermines the kind of logging (debug/info/warning/error).Should any additional member of the
callback_databe added to the message?If this approach is considered to be good, I'd carry it over to all the other occurances of a debug callback.
Build tested on Win11 with VS2026. Run tested on Win11 with NVidia GPU.
Fixes #1558
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: