spirv-opt: Fix assertion with fp8#6677
Open
GinShio wants to merge 1 commit into
Open
Conversation
s-perron
reviewed
May 6, 2026
s-perron
left a comment
s-perron
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but I want to make sure we have a follow up issue referenced.
GinShio
commented
May 7, 2026
Comment on lines
+1357
to
+1359
| // TODO: hex_float.h contains some errors when converting float32 to | ||
| // smaller floating point types, which causes incorrect results. Please see | ||
| // https://github.com/KhronosGroup/glslang/issues/4241 for details. |
Contributor
Author
There was a problem hiding this comment.
Add TODO comment, And remove FIXME
Contributor
Author
There was a problem hiding this comment.
Sorry, 0x1.4p0 is 1.25 in dec... I confused 0x1.4p0 -> 1.4...
Using 0x1.7p0 presents this issue.
This patch fixes an assertion crash in Debug build. However, hex_float.h contains some errors when converting float32 to smaller floating point types, which causes incorrect results. Please see KhronosGroup/glslang#4241 for details. fixes: KhronosGroup#6533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an assertion crash in Debug build.
However, hex_float.h contains some errors when converting float32 to smaller floating point types, which causes incorrect results. Please see KhronosGroup/glslang#4241 for details.
fixes: #6533