Adapt to latest llvm changes#3859
Merged
Merged
Conversation
Contributor
|
@svenvh , @MrSidims , @maarquitos14, should this PR be merged now, or wait for CI to pick up an up-to-date LLVM? Context: the only failing checks are the two out-of-tree Linux jobs. They fail because CI hasn't yet picked up fresh LLVM yet. The in-tree jobs, built against llvm-project main, pass. |
wenju-he
added a commit
to intel/llvm
that referenced
this pull request
Jul 11, 2026
Fix llvm-spirv LLVMToSPIRVDbgTran.cpp build error by cherry-picking KhronosGroup/SPIRV-LLVM-Translator#3859 d58b056 changed getRetainedNodes() return type to MDNodeArray.
Co-authored-by: Yury Plyakhin <yury.plyakhin@intel.com>
Member
It might be a while before new apt packages are available, and we can't really wait for that. It means the out-of-tree CI jobs will be broken until then, but that's what it is. Let's wait for CI to finish after I applied your suggestion, and then we merge. |
svenvh
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some merged changes from llvm-project breaks compilation and tests of translator.
#187927:
DISubprogram::getRetainedNodes()returnsMDNodeArraynow, instead ofDINodeArray.DIGlobalVariablewhose scope is aDILocalScope) was on theglobals:list of theDICompileUnit. This has changed now: it must be onretainedNodesof the owningDISubprogram, otherwise LLVM IR verifier will reject it.#207347:
llcrequiresSPV_INTEL_function_pointersto be enabled when using function pointer in SPIRV BE.