Fix SPV_INTEL_function_pointers translation with untyped pointers#3830
Draft
Qi-Ye-079 wants to merge 1 commit into
Draft
Fix SPV_INTEL_function_pointers translation with untyped pointers#3830Qi-Ye-079 wants to merge 1 commit into
Qi-Ye-079 wants to merge 1 commit into
Conversation
Contributor
Author
|
@vmaksimo Please take a look. P.S. For the testcases, I only enabled the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
SPV_INTEL_function_pointersenabled, when the Reader handles indirect function calls with untyped function pointer (enabled bySPV_KHR_untyped_pointers), the reverse translation will crash with assertion error, because it still assumes the function pointer is always typed.This PR adds proper handling for untyped function pointer in the Reader in case of an indirect function call.
AI-assisted by: Claude Opus 4.8